Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-17632

[Python][C++] Add details of where is lib arrow being found during build

    XMLWordPrintableJSON

Details

    Description

      As discussed here:

      https://github.com/apache/arrow/pull/13892#discussion_r963587046

      We used to show information of where Arrow was being found during build:

        message(STATUS "Arrow version: ${ARROW_VERSION} (${ARROW_FIND_APPROACH})")
        message(STATUS "Arrow SO and ABI version: ${ARROW_SO_VERSION}")
        message(STATUS "Arrow full SO version: ${ARROW_FULL_SO_VERSION}")
        message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
        message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
        message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}") 

      We should  add back the messages to ArrowConfig.cmake.in.

      As proposed on the comment if we want to add message(STATUS ...), it's better that we check Arrow_FIND_QUIETLY like:

      if(NOT Arrow_FIND_QUIETLY)
        message(STATUS ...)
      endif()

      Arrow_FIND_QUIETLY is TRUE only when an user specify QUIET explicitly like find_package(Arrow QUIET).

      Attachments

        Issue Links

          Activity

            People

              dhruv9vats Dhruv Vats
              raulcd Raúl Cumplido
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1.5h
                  1.5h