Details
-
Improvement
-
Status: Open
-
Major
-
Resolution: Unresolved
-
None
-
None
Description
As paleolimbot observes here, we should avoid adding additional complexity or indirection in how expressions/bindings are defined--it's complex enough as is. We have helper functions build_expr (used with Acero, wrapper around Expression$create, returns Expression) and eval_array_expression (for eager computation on Arrays, wrapper around call_function) that wrap input arguments as Scalars or whatever, but they also do some special casing for functions that need custom handling.
However, since those functions were initially written, we've developed other ways to handle these special cases more explicitly, and not all operations pass through these helper functions. We should pull out the special cases and define those functions/bindings explicitly and only use these helpers in the simple case where no extra logic is required.