[ARROW-17571] [Benchmarks] Default build for PyArrow seems to be debug

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 10.0.0
• Component/s: Benchmarking, Python
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/32821
• Assignee: Alenka Frim
• Reporter: Alenka Frim
• Created: 30/Aug/22 16:00
• Updated: 11/Jan/23 11:51
• Resolved: 01/Sep/22 14:59

Description

After a benchmark regression was identified in the Python refactoring PR we identified the cause is in the build script for benchmarks. In the file dev/conbench_envs/hooks.sh the script used to build PyArrow is ci/scripts/python_build.sh where the default for PyArrow build type is set to debug (assuming CMAKE_BUILD_TYPE isn't defined)

See:
https://github.com/apache/arrow/blob/74dae618ed8d6b492bf3b88e3b9b7dfd4c21e8d8/dev/conbench_envs/hooks.sh#L60-L62
https://github.com/apache/arrow/blob/93b63e8f3b4880927ccbd5522c967df79e926cda/ci/scripts/python_build.sh#L55 

I think we need to change the build type to release in dev/conbench_envs/hooks.sh (build_arrow_python()) or maybe better to set the variable CMAKE_BUILD_TYPE to release in dev/conbench_envs/benchmarks.env.

Issue Links

• links to: GitHub Pull Request #14010