Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-17394

[C++][Parquet] Fix parquet_static dependencies

    XMLWordPrintableJSON

Details

    Description

      See also: https://github.com/microsoft/vcpkg/issues/22552#issuecomment-1211341648

      I tried #22552 (comment) (that is based on Apache Arrow 7.0.0).

      The following dependencies are missed from link command line:

      • vcpkg_installed/x64-linux/debug/lib/libthriftd.a
      • vcpkg_installed/x64-linux/debug/lib/liblz4d.a
      • vcpkg_installed/x64-linux/debug/lib/libbrotli{enc,dec,common}-static.a

      It seems that thrift::thrift, lz4::lz4 and unofficial::brotli::brotli{enc,dec,common}-static are missed in arrow_static dependencies:

      $ grep INTERFACE_LINK_LIBRARIES vcpkg_installed/x64-linux/share/arrow/ArrowTargets.cmake 
        INTERFACE_LINK_LIBRARIES "OpenSSL::Crypto;OpenSSL::SSL;BZip2::BZip2;Snappy::snappy;ZLIB::ZLIB;zstd::libzstd_static;re2::re2;Threads::Threads;rt;\$<LINK_ONLY:>"
      

      I'm not sure that this is a problem in Apache Arrow's CMake configuration or patches in vcpkg.

      Attachments

        Issue Links

          Activity

            People

              kou Kouhei Sutou
              kou Kouhei Sutou
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h