[ARROW-17096] [C++] Mode kernel incorrect for boolean inputs

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 8.0.0
• Fix Version/s: 9.0.0
• Component/s: C++, Python
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/32402
• Assignee: Yibo Cai
• Reporter: NULL
• Created: 15/Jul/22 19:58
• Updated: 11/Jan/23 11:48
• Resolved: 19/Jul/22 12:05

Description

In [1]: import pyarrow.compute as pc

In [2]: import pyarrow as pa

In [3]: pa.__version__
Out[3]: '8.0.0'

In [4]: pc.mode(pa.array([True, True]))
# Correct
Out[4]:
<pyarrow.lib.StructArray object at 0x1266d5c60>
-- is_valid: all not null
-- child 0 type: bool
  [
    true
  ]
-- child 1 type: int64
  [
    2
  ]

# Incorrect
In [5]: pc.mode(pa.array([True, False]), 2)
Out[5]:
<pyarrow.lib.StructArray object at 0x1262110c0>
-- is_valid: all not null
-- child 0 type: bool
  [
    false, # should be true
    false
  ]
-- child 1 type: int64
  [
    1,
    1
  ] 

Issue Links

• links to: GitHub Pull Request #13646