[ARROW-16870] [C++] lld does not like --as-needed flag

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.0.0
• Fix Version/s: 10.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/32194
• Assignee: Percy Camilo Triveño Aucahuasi
• Reporter: Will Jones
• Created: 21/Jun/22 15:47
• Updated: 11/Jan/23 11:47
• Resolved: 12/Sep/22 13:12

Description

I've been getting this annoying linking error if I try to build examples using Clang 13 on MacOS:

[build] [807/827] Linking CXX executable debug/flight-grpc-example
[build] FAILED: debug/flight-grpc-example
[build] : && /Library/Developer/CommandLineTools/usr/bin/c++ -Qunused-arguments -fcolor-diagnostics  ...
[build] ld: unknown option: --no-as-needed
[build] clang: error: linker command failed with exit code 1 (use -v to see invocation)

Should we drop the --as-needed or should I carve out for Apple? cc davidli

My workaround has been to comment out these lines: https://github.com/apache/arrow/blob/982ea6c4d382d1e85164f09b711e87938eaa674a/cpp/examples/arrow/CMakeLists.txt#L39-L40

Issue Links

• links to: GitHub Pull Request #14077