Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-16786

[Docs] Update "closed without merge" in pull request note

    XMLWordPrintableJSON

Details

    Description

      https://arrow.apache.org/docs/developers/overview.html#pull-request-and-review

      A side effect of this way of merging is that your pull request will appear in the GitHub interface to have been “closed without merge”. Do not be alarmed: if you look at the bottom, you will see a message that says @user closed this in $COMMIT. In the commit message of that commit, the merge tool adds the pull request description, a link back to the pull request, and attribution to the contributor and any co-authors.

      We have changed to use the "merge" feature of GitHub by ARROW-16602 to show "merged" mark not "closed without merge" mark on GitHub. We should update the note.

      alenkaf Do you want to work on this?

      Attachments

        Issue Links

          Activity

            People

              alenka Alenka Frim
              kou Kouhei Sutou
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m