Details
-
Improvement
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
Description
Context: https://github.com/apache/arrow/pull/13244#discussion_r889780669
target_include_directories() in cmake 3.10 or earlier doesn't support INTERFACE against IMPORTED target, so we have to check cmake version like below:
if(CMAKE_VERSION VERSION_LESS 3.11) set_target_properties(xsimd PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${XSIMD_INCLUDE_DIR}") else() target_include_directories(xsimd INTERFACE "${XSIMD_INCLUDE_DIR}") endif()
Above code is duplicated for some targets. There are also some targets (e.g. ucx::ucx) missed the check.
We can add a function arrow_imported_target_interface_include_directories() to make it simpler.
Attachments
Issue Links
- links to