Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-16751

[C++] Add support for building bundled ucx with CMake 3.5

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 9.0.0
    • C++

    Description

      Context: https://github.com/apache/arrow/pull/13244#discussion_r889780669

      target_include_directories() in cmake 3.10 or earlier doesn't support INTERFACE against IMPORTED target, so we have to check cmake version like below:

      if(CMAKE_VERSION VERSION_LESS 3.11)
        set_target_properties(xsimd PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
                                               "${XSIMD_INCLUDE_DIR}")
      else()
        target_include_directories(xsimd INTERFACE "${XSIMD_INCLUDE_DIR}")
      endif()
      

      Above code is duplicated for some targets. There are also some targets (e.g. ucx::ucx) missed the check.
      We can add a function arrow_imported_target_interface_include_directories() to make it simpler.

      Attachments

        Issue Links

          Activity

            People

              yibocai Yibo Cai
              yibocai Yibo Cai
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m