[ARROW-16683] [C++] Bundled gflags misses dependency

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/20264
• Assignee: Kouhei Sutou
• Reporter: Kouhei Sutou
• Created: 30/May/22 07:15
• Updated: 11/Jan/23 11:45
• Resolved: 30/May/22 16:52

Description

https://lists.apache.org/thread/15470pntvv5p2x49qwpkdv0trn6d9p6j

cmake .. -G "Visual Studio 16 2019" -A x64 -DARROW_BUILD_TESTS=ON

says it can't find gflags and will build them from source:

-- Building gflags from source
-- Added static library dependency gflags::gflags_static: C:/Users/avertleyb/git/arrow/cpp/build/gflags_ep-prefix/src/gflags_ep/lib/gflags_static.lib

The second step - 

cmake --build . --config Release

right away complains about this library:

LINK : fatal error LNK1181: cannot open input file 'C:\Users\avertleyb\git\arrow\cpp\build\gflags_ep-prefix\src\gflags_ep\lib\gflags_static.lib' [C:\Users\avertleyb\git\arrow\cpp\build\src\arrow\arrow_bundled_dependencies.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'C:\Users\avertleyb\git\arrow\cpp\build\CMakeFiles\b033194e6d32d6a2595cc88c82
72e4b2\arrow_bundled_dependencies.lib.rule;C:\Users\avertleyb\git\arrow\cpp\build\CMakeFiles\672df30e18a621ddf9c15292835268fd\arrow_bundled_dependencies.rule' exited with code 1181. [C:\Users\avertleyb\git\arrow\cpp\build\src\arrow\arro
w_bundled_dependencies.vcxproj]

However it proceeds with the build, and when the build ends, the library is there:

C:\Users\avertleyb\git\arrow\cpp\build>dir C:\Users\avertleyb\git\arrow\cpp\build\gflags_ep-prefix\src\gflags_ep\lib\gflags_static.lib
 Volume in drive C is Windows
 Volume Serial Number is 3E24-1FC6

 Directory of C:\Users\avertleyb\git\arrow\cpp\build\gflags_ep-prefix\src\gflags_ep\lib

05/26/2022  02:40 PM           672,310 gflags_static.lib
               1 File(s)        672,310 bytes
               0 Dir(s)  288,920,072,192 bytes free

Issue Links

• links to: GitHub Pull Request #13256