[ARROW-16253] [R] Helper function for casting from float to duration via int64()

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0.0
• Component/s: R
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/31647
• Assignee: Dragoș Moldovan-Grünfeld
• Reporter: Dragoș Moldovan-Grünfeld
• Created: 20/Apr/22 09:14
• Updated: 11/Jan/23 11:42
• Resolved: 11/May/22 09:44

Description

This logic is used in several places in R/dplyr-funcs-datetime.R and it would be great if we could separate it into a standalone helper function. The main purpose would be to indicate the float -> int64 -> duration casting chain is being used.

 

Originally raised by jonkeane during a review for one of the lubridate bindings.

https://github.com/apache/arrow/pull/12757/#discussion_r852389088

I've seen this line in a few PRs recently — this is to get around the fact that we do not have float durations, yeah? I wonder if we should put that into a helper function. Not so much to save lines of code, but to encapsulate that we have this one workaround that we're using in all of these places.

Then if that workaround is not necessary (or if we find a better one) we can change it in one place. We don't need to do that here, but it would be good to make a Jira for that if we do want to.

Issue Links

• is a child of: ARROW-16155 [R] lubridate functions for 9.0.0
• is related to: ARROW-15862 [C++] Provide a way to go from numeric to duration
• links to: GitHub Pull Request #13055