[ARROW-16152] [C++] Typo that causes segfault with unknown functions in Substrait

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/31559
• Assignee: Dewey Dunnington
• Reporter: Dewey Dunnington
• Created: 08/Apr/22 12:19
• Updated: 11/Jan/23 11:42
• Resolved: 08/Apr/22 15:24

Description

There is a typo in ExtensionSet::Make() that causes a crash whenever somebody provides an unsupported function into the Substrait consumer. It looks like this was a copy/paste error here where type_ids should be function_ids.

https://github.com/apache/arrow/blob/a935c81b595d24179e115d64cda944efa93aa0e0/cpp/src/arrow/engine/substrait/extension_set.cc#L167-L168

To reproduce via the R bindings:

arrow:::do_exec_plan_substrait('
{
  "extensionUris": [
    {
      "extensionUriAnchor": 1
    }
  ],
  "extensions": [
    {
      "extensionFunction": {
        "extensionUriReference": 1,
        "functionAnchor": 2,
        "name": "abs_checked"
      }
    }
  ],
  "relations": [
    {
      "rel": {
        "project": {
          "input": {
            "read": {
              "baseSchema": {
                "names": [
                  "letter",
                  "number"
                ],
                "struct": {
                  "types": [
                    {
                      "string": {

                      }
                    },
                    {
                      "i32": {

                      }
                    }
                  ]
                }
              },
              "namedTable": {
                "names": [
                  "named_table_1"
                ]
              }
            }
          },
          "expressions": [
            {
              "scalarFunction": {
                "functionReference": 2,
                "args": [
                  {
                    "selection": {
                      "directReference": {
                        "structField": {
                          "field": 1
                        }
                      }
                    }
                  }
                ],
                "outputType": {

                }
              }
            }
          ]
        }
      }
    }
  ]
}
')

Issue Links

• links to: GitHub Pull Request #12836