[ARROW-15952] [C++] Document Array::accept() and ArrayVisitor

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.0.0
• Fix Version/s: 8.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/31378
• Assignee: Will Jones
• Reporter: Will Jones
• Created: 16/Mar/22 17:03
• Updated: 11/Jan/23 11:40
• Resolved: 17/Mar/22 09:45

Description

We mention in the docs that:

The classes arrow::Array and its subclasses provide strongly-typed accessors with support for the visitor pattern and other affordances.

But ArrayVisitor class and the Array::Accept() method are missing from the API docs. We should add those, and potentially also provide an example of using the visitor.

Likely worth doing the same for TypeVisitor and ScalarVisitor. It would also be nice to document the performance implication of using ScalarVisitor vs ArrayVisitor. Also we use an "inline" version of the visitors; is that something we do/should expose in the API as well?

Issue Links

• links to: GitHub Pull Request #12651