Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-15854

[C++] Refine csv writer - populate columns in normal order

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 8.0.0
    • C++

    Description

      CSV writer populates columns in reverse order, each row is constructed from last cell to first cell.
      Populating columns in normal order makes the code easier to follow, and offers better optimization chances. E.g., EscapeReverse [1] is the hotspot for quoted string benchmark, it's hard to improve if chars are scanned in reverse order, but may benefit from simd if scanned in normal order.

      [1] https://github.com/apache/arrow/blob/master/cpp/src/arrow/csv/writer.cc#L141-L150

      Attachments

        Issue Links

          Activity

            People

              yibocai Yibo Cai
              yibocai Yibo Cai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 4h 40m
                  4h 40m