Details
-
Improvement
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
Description
CSV writer populates columns in reverse order, each row is constructed from last cell to first cell.
Populating columns in normal order makes the code easier to follow, and offers better optimization chances. E.g., EscapeReverse [1] is the hotspot for quoted string benchmark, it's hard to improve if chars are scanned in reverse order, but may benefit from simd if scanned in normal order.
[1] https://github.com/apache/arrow/blob/master/cpp/src/arrow/csv/writer.cc#L141-L150
Attachments
Issue Links
- links to