[ARROW-1543] [C++] row_wise_conversion example doesn't correspond to ListBuilder constructor arguments

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.7.0
• Fix Version/s: 0.8.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/17558
• Assignee: Wes McKinney
• Reporter: Johan Peltenburg
• Created: 15/Sep/17 10:54
• Updated: 11/Jan/23 07:15
• Resolved: 04/Oct/17 15:05

Description

In the row_wise_conversion code example we find:

    std::shared_ptr<DoubleBuilder> components_values_builder =
        std::make_shared<DoubleBuilder>(arrow::default_memory_pool());
    arrow::ListBuilder components_builder(arrow::default_memory_pool(),
        components_values_builder);

This generates some compile time errors since the second argument of the ListBuilder constructor expects a unique pointer.

However, I guess the example shows the correct case, where we want to still be able to use the DoubleBuilder after constructing the ListBuilder, so I probably shouldn't std::move it to the constructor as a unique_ptr.

I'm not sure how to fix this as I don't know which functionality is desired.

Issue Links

• links to: GitHub Pull Request #1157