Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-1543

[C++] row_wise_conversion example doesn't correspond to ListBuilder constructor arguments

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.7.0
    • Fix Version/s: 0.8.0
    • Component/s: C++

      Description

      In the row_wise_conversion code example we find:

          std::shared_ptr<DoubleBuilder> components_values_builder =
              std::make_shared<DoubleBuilder>(arrow::default_memory_pool());
          arrow::ListBuilder components_builder(arrow::default_memory_pool(),
              components_values_builder);
      

      This generates some compile time errors since the second argument of the ListBuilder constructor expects a unique pointer.

      However, I guess the example shows the correct case, where we want to still be able to use the DoubleBuilder after constructing the ListBuilder, so I probably shouldn't std::move it to the constructor as a unique_ptr.

      I'm not sure how to fix this as I don't know which functionality is desired.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                wesmckinn Wes McKinney
                Reporter:
                johanpel Johan Peltenburg
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: