Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-15316

[R] Make a one-function pointer function

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 7.0.0
    • R

    Description

      In ARROW-15173 PR we added backwards compatibly to pointers between R and Python where we use `external_pointer_addr_double()` with old python versions. We could take a number of the blocks like:

       if (pyarrow_version() >= pyarrow_version_pointers_changed) {
          x$`_export_to_c`(schema_ptr)
        } else {
          x$`_export_to_c`(external_pointer_addr_double(schema_ptr))
        }
      

      to

      x$`_export_to_c`(backwards_compatible_pointer(schema_ptr))
      

      with backwards_compatible_pointer including the if/else

      Attachments

        Issue Links

          Activity

            People

              dragosmg Dragoș Moldovan-Grünfeld
              jonkeane Jonathan Keane
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2.5h
                  2.5h