[ARROW-15301] [R] Discussion: move testthat test helpers to R/test-helpers.R

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Fix Version/s: 9.0.0
• Component/s: R
• External issue URL: https://github.com/apache/arrow/issues/30791
• Assignee: Unassigned
• Reporter: Dragoș Moldovan-Grünfeld
• Created: 11/Jan/22 14:29
• Updated: 11/Jan/23 11:36
• Resolved: 04/May/22 12:15

Description

Would it make sense to have all custom expectations in R/ , maybe R/test-helpers.R ? Reasons:

• edit(added on 12/01/2022): probably the most important point is these files are source by devtools::load_all() and, thus, helper functions are available interactively.
• easier for newbies to read a file and figure out what custom testthat helpers we have
• easier to document
• respects the testthat author's suggestion to have them there

Currently we have 17 different custom expectations, all defined in different files.
A follow-up thought: maybe move all helpers there (is., as_, compare_, verify etc).