[ARROW-15220] [C++] Remove bool specializations of bit block counter operations

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 7.0.0
• Component/s: C++
• Labels: good-first-issue pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/30720
• Assignee: Eduardo Ponce
• Reporter: Eduardo Ponce
• Created: 30/Dec/21 09:36
• Updated: 11/Jan/23 08:45
• Resolved: 30/Dec/21 20:28

Description

We can simplify the logical bit operations in util/bit_block_counter.h so that the specializations for bool and T can be merged because C++ guarantees that for boolean types: (bool)(a & b) == a && b. Note the explicit cast which corresponds to the return type T in these functions.

// Works correctly for bool and integer types
template <typename T>
T bit_and(T x, T y) {
  return x & y;
}

This change has a higher impact for ternary bitwise versions, see for example here

Issue Links

• links to: GitHub Pull Request #12052