[ARROW-14700] [R] [C++] Valgrind error on CSV parse + timestamp

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.0.0
• Component/s: C++, R
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/30240
• Assignee: David Li
• Reporter: Jonathan Keane
• Created: 12/Nov/21 16:42
• Updated: 11/Jan/23 08:41
• Resolved: 17/Nov/21 09:28

Description

Our valgrind nightly is erroring on csv (and possibly only timestamp conversion):

==5098==    by 0xE150F84: Parse (parser.cc:522)
==5098==    by 0xE150F84: arrow::csv::BlockParser::ParseFinal(std::vector<nonstd::sv_lite::basic_string_view<char, std::char_traits<char> >, std::allocator<nonstd::sv_lite::basic_string_view<char, std::char_traits<char> > > > const&, unsigned int*) (parser.cc:566)
==5098==    by 0xE15D7A1: operator() (reader.cc:424)
==5098==    by 0xE15D7A1: operator() (async_generator.h:275)
==5098==    by 0xE15D7A1: __invoke_impl<arrow::Future<arrow::csv::(anonymous namespace)::ParsedBlock>, arrow::MakeMappedGenerator<arrow::csv::(anonymous namespace)::CSVBlock, arrow::csv::(anonymous namespace)::BlockParsingOperator, arrow::Result<arrow::csv::(anonymous namespace)::ParsedBlock>, arrow::csv::(anonymous namespace)::ParsedBlock>::MapCallback&, const arrow::csv::(anonymous namespace)::CSVBlock&> (invoke.h:60)
==5098==    by 0xE15D7A1: __invoke_r<arrow::Future<arrow::csv::(anonymous namespace)::ParsedBlock>, arrow::MakeMappedGenerator<arrow::csv::(anonymous namespace)::CSVBlock, arrow::csv::(anonymous namespace)::BlockParsingOperator, arrow::Result<arrow::csv::(anonymous namespace)::ParsedBlock>, arrow::csv::(anonymous namespace)::ParsedBlock>::MapCallback&, const arrow::csv::(anonymous namespace)::CSVBlock&> (invoke.h:142)
==5098==    by 0xE15D7A1: std::_Function_handler<arrow::Future<arrow::csv::(anonymous namespace)::ParsedBlock> (arrow::csv::(anonymous namespace)::CSVBlock const&), std::function<arrow::Future<arrow::csv::(anonymous namespace)::ParsedBlock> ()> arrow::MakeMappedGenerator<arrow::csv::(anonymous namespace)::CSVBlock, arrow::csv::(anonymous namespace)::BlockParsingOperator, arrow::Result<arrow::csv::(anonymous namespace)::ParsedBlock>, arrow::csv::(anonymous namespace)::ParsedBlock>(std::function<arrow::Future<arrow::csv::(anonymous namespace)::CSVBlock> ()>, arrow::csv::(anonymous namespace)::BlockParsingOperator)::MapCallback>::_M_invoke(std::_Any_data const&, arrow::csv::(anonymous namespace)::CSVBlock const&) (std_function.h:292)
==5098==    by 0xE1662A8: operator() (std_function.h:622)
==5098==    by 0xE1662A8: arrow::MappingGenerator<arrow::csv::(anonymous namespace)::CSVBlock, arrow::csv::(anonymous namespace)::ParsedBlock>::Callback::operator()(arrow::Result<arrow::csv::(anonymous namespace)::CSVBlock> const&) (async_generator.h:247)
==5098== 
  test-dataset-csv.R:61:3 [success]
End test: CSV dataset

https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=15258&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=15019

could be related to/triggered by:
https://github.com/apache/arrow/commit/a9f2091f8518590c72d25452dc60c8173ee6223c
https://github.com/apache/arrow/commit/f3f4423f4e952c49e14ed2b11e21809b6e98b666

Issue Links

• links to: GitHub Pull Request #11695