[ARROW-14679] [R] [C++] Handle suffix argument in joins

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.0.0
• Component/s: C++, R
• Labels: pull-request-available query-engine
• External issue URL: https://github.com/apache/arrow/issues/18938
• Assignee: Vibhatha Lakmal Abeykoon
• Reporter: Jonathan Keane
• Created: 11/Nov/21 18:53
• Updated: 11/Jan/23 08:41
• Resolved: 21/Mar/22 16:22

Description

If there is a name collision, we need to do something https://github.com/apache/arrow/blob/a3746040d8a3ddb84bab6c7ca4771b6c120e3444/r/R/dplyr-join.R#L31

A few notes:

• arrow doesn't seem to actually be able to apply the prefixes (I'm getting errors when trying), I couldn't tell if there were tests of this — I couldn't find any, so I'm not sure if I'm calling this wrong or if it's not working at all.
• arrow always appends the affixes (where as dplyr only adds them if there is a name collision)
• arrow only supports prefixes (can we configure this, or ask the clients to provide new names?) in the tests I wrote I've worked around this, but it would be nice to be able to match dplyr/allow things other than prefix

Issue Links

• links to: GitHub Pull Request #11682
• links to: GitHub Pull Request #12113

Sub-Tasks

• [C++] Handle suffix argument in joins: Resolved