[ARROW-14609] [R] left_join by argument error message mismatch

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 7.0.0
• Component/s: R
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/30155
• Assignee: Dragoș Moldovan-Grünfeld
• Reporter: Nicola Crane
• Created: 05/Nov/21 12:09
• Updated: 11/Jan/23 08:41
• Resolved: 20/Jan/22 16:33

Description

We should use the dplyr error message which is clear when the "by" argument to joins is not correctly specified.

> left_join(iris, iris, by  = "made_up_colname")
Error: Join columns must be present in data.
x Problem with `made_up_colname`.
Run `rlang::last_error()` to see where the error occurred.

> left_join(arrow_table(iris), arrow_table(iris), by = "made_up_colname")
Error in handle_join_by(by, x, y) : 
  all(names(by) %in% names(x)) is not TRUE

Issue Links

• links to: GitHub Pull Request #12179