[ARROW-14436] [C++] Disable color diagnostics when compiling with ccache

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Cannot Reproduce
• Fix Version/s: 7.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/30000
• Assignee: Eduardo Ponce
• Reporter: Krisztian Szucs
• Created: 22/Oct/21 09:26
• Updated: 11/Jan/23 08:39
• Resolved: 16/Dec/21 20:33

Description

Copied from https://github.com/apache/arrow/issues/11279

Steps to reproduce:

Compile arrow_objlib with ccache, clang and CCACHE_DEBUG=1 CCACHE_LOGFILE=./ccache.log
Find in ./ccache.log:
Failed; falling back to running the real compiler
Result: unsupported compiler option
Dropping -fcolor-diagnostics fixes the issue.

I suggest either opting into color diagnostics with WITH_COLOR_DIAGNOSTICS or adding a way to disable it via DISABLE_COLOR_DIAGNOSTICS.
It would be good if this wouldn't be tied to ARROW_USE_CCACHE since its also relevant for:
-DARROW_USE_CCACHE=OFF -DCMAKE_CXX_COMPILER_LAUNCHER=emscripten_ccache.

Issue Links

• links to: GitHub Pull Request #11518