[ARROW-14361] [C++] Define a DEFAULT value for ARROW_SIMD_LEVEL

• Type: New Feature
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/29929
• Assignee: Yibo Cai
• Reporter: Krisztian Szucs
• Created: 18/Oct/21 10:33
• Updated: 11/Jan/23 08:39
• Resolved: 19/Oct/21 11:32

Description

In order to enable ARROW_HAVE_NEON CMake flag on ARM architectures ARROW_SIMD_LEVEL option must be set to not "NONE", see https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L444

The default value for ARROW_SIMD_LEVEL is SSE4_2 which is a bit misleading on ARM64, it should rather be NEON which is not listed as a valid option for ARROW_SIMD_LEVEL. We may have a "MAX" default value similarly to the ARROW_RUNTIME_SIMD_LEVEL option, see https://github.com/apache/arrow/blob/master/cpp/cmake_modules/DefineOptions.cmake#L115

Original github comment: https://github.com/apache/arrow/pull/11433#discussion_r729852835

cc yibocai apitrou

Issue Links

• links to: GitHub Pull Request #11456