Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-14361

[C++] Define a DEFAULT value for ARROW_SIMD_LEVEL

    XMLWordPrintableJSON

Details

    • New Feature
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 6.0.0
    • C++

    Description

      In order to enable ARROW_HAVE_NEON CMake flag on ARM architectures ARROW_SIMD_LEVEL option must be set to not "NONE", see https://github.com/apache/arrow/blob/master/cpp/cmake_modules/SetupCxxFlags.cmake#L444

      The default value for ARROW_SIMD_LEVEL is SSE4_2 which is a bit misleading on ARM64, it should rather be NEON which is not listed as a valid option for ARROW_SIMD_LEVEL. We may have a "MAX" default value similarly to the ARROW_RUNTIME_SIMD_LEVEL option, see https://github.com/apache/arrow/blob/master/cpp/cmake_modules/DefineOptions.cmake#L115

      Original github comment: https://github.com/apache/arrow/pull/11433#discussion_r729852835

      cc yibocai apitrou

      Attachments

        Issue Links

          Activity

            People

              yibocai Yibo Cai
              kszucs Krisztian Szucs
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2.5h
                  2.5h