Details
-
Improvement
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
Description
The vendored base64 code looks suboptimal. [1]
We should at least upgrade to latest upstream code which improved a lot. [2]
Maybe adopt more optimized implementation if base64 performance matters for arrow. [3]
[1] https://github.com/apache/arrow/blob/master/cpp/src/arrow/vendored/base64.cpp#L49
[2] https://github.com/ReneNyffenegger/cpp-base64/blob/master/base64.cpp#L129
[3] https://github.com/aklomp/base64
Attachments
Issue Links
- links to