Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-14269

[C++] Consolidate utf8 benchmark

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 6.0.0
    • C++

    Description

      I find some trivial (and obviously irrelevant) changes to UTF8 validation code may cause big variances to benchmark result.
      UTF8 validation functions are inlined and called directly in benchmark. The compiler may try to optimize them together with the benchmark loop.
      Un-inline the benchmark-ed functions makes the result predictable and explainable.

      Attachments

        Issue Links

          Activity

            People

              yibocai Yibo Cai
              yibocai Yibo Cai
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3h 10m
                  3h 10m