Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-1402

[C++] Possibly deprecate public APIs that use MutableBuffer

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: C++
    • Labels:
      None

      Description

      I am not sure it is useful to expose arrow::MutableBuffer as the out argument in functions like arrow::AllocateBuffer. See e.g. http://arrow.apache.org/docs/cpp/namespacearrow.html#a4e4daf985e41d6879c9dbb0131157c51

      In my experience this is more of a nuisance than anything, as mutability is a dynamic property of buffers (we have buffer->is_mutable() on base instances). If we were doing a lot of compile time reasoning about buffers, that would be a different story, but we are not.

      I don't think we should nix the MutableBuffer class, just return pointers to base from functions. We can still get it back with std::dynamic_pointer_cast.

        Attachments

          Activity

            People

            • Assignee:
              wesmckinn Wes McKinney
              Reporter:
              wesmckinn Wes McKinney
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: