Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-13994

[Doc][C++] Build document misses git submodule update

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 6.0.0
    • C++, Documentation
    • None
    • Fedora linux with gcc version 10.3.1 20210422 compiler

    Description

      arrow-ipc-read-write-test fails after doing a debug build and then testing it on git commit 672149b68f3c8878e0f62a1bfde122092d734c0d
      when using gcc version 10.3.1 20210422 on Fedora linux

      Attachments

        1. LastTest.log
          513 kB
          Benson Muite

        Activity

          kou Kouhei Sutou added a comment -

          Could you show full log for the test?

          kou Kouhei Sutou added a comment - Could you show full log for the test?
          kou Kouhei Sutou added a comment -

          'GetTestResourceRoot(&root)' failed with IOError: Test resources not found, set ARROW_TEST_DATA to <repo root>/testing/data

          You need to download submoduled test data by git submodule update --init --recursive. It seems that this instruction is missed in https://arrow.apache.org/docs/developers/cpp/building.html . We need to update the document.

          kou Kouhei Sutou added a comment - 'GetTestResourceRoot(&root)' failed with IOError: Test resources not found, set ARROW_TEST_DATA to <repo root>/testing/data You need to download submoduled test data by git submodule update --init --recursive . It seems that this instruction is missed in https://arrow.apache.org/docs/developers/cpp/building.html . We need to update the document.
          baksmj Benson Muite added a comment -

          Thanks. Can make a pull request to update the documentation.

          baksmj Benson Muite added a comment - Thanks. Can make a pull request to update the documentation.
          kou Kouhei Sutou added a comment -

          Thanks. Please go ahead.
          You can use this issue when you associate an issue with the new pull request. (You don't need to create one more JIRA issue.)

          kou Kouhei Sutou added a comment - Thanks. Please go ahead. You can use this issue when you associate an issue with the new pull request. (You don't need to create one more JIRA issue.)
          baksmj Benson Muite added a comment -

          This test also fails on Cent OS 8. Build steps

           

          dnf -y update
          dnf -y install cmake gcc gcc-c++ make python39 git
          git clone https://github.com/apache/arrow.git
          cd arrow
          
          git submodule update --init --recursive
          
          cd cpp
          mkdir debug 
          cd debug 
          cmake -DCMAKE_BUILD_TYPE=Debug -DARROW_BUILD_TESTS=ON .. 
          make -j2  unittest
          


          CI tests only use Ubuntu, Mac OS X and MinGW

           

          Line 98 in arrow/cpp/build-support/run-test.sh
          needs to be changed from

          | ${PYTHON:-python} $ROOT/build-support/asan_symbolize.py \
          to

          | ${PYTHON:-python3} $ROOT/build-support/asan_symbolize.py \

           

          since Cent OS 8 uses python3 command to distinguish from python which has typically been python2

           

          baksmj Benson Muite added a comment - This test also fails on Cent OS 8. Build steps   dnf -y update dnf -y install cmake gcc gcc-c++ make python39 git git clone https: //github.com/apache/arrow.git cd arrow git submodule update --init --recursive cd cpp mkdir debug cd debug cmake -DCMAKE_BUILD_TYPE=Debug -DARROW_BUILD_TESTS=ON .. make -j2  unittest CI tests only use Ubuntu, Mac OS X and MinGW   Line 98 in arrow/cpp/build-support/run-test.sh needs to be changed from | ${PYTHON:-python} $ROOT/build-support/asan_symbolize.py \ to | ${PYTHON:-python3} $ROOT/build-support/asan_symbolize.py \   since Cent OS 8 uses python3 command to distinguish from python which has typically been python2  
          baksmj Benson Muite added a comment -

          Same error in log file on Cent OS 8

          'GetTestResourceRoot(&root)' failed with IOError: Test resources not found, set ARROW_TEST_DATA to <repo roo
          t>/testing/data

          baksmj Benson Muite added a comment - Same error in log file on Cent OS 8 'GetTestResourceRoot(&root)' failed with IOError : Test resources not found, set ARROW_TEST_DATA to <repo roo t>/testing/data
          baksmj Benson Muite added a comment -

          After using exporting ARROW_TEST_DATA all test pass, suggested steps
          dnf -y update
          dnf -y install cmake gcc gcc-c++ make python39 git
          git clone https://github.com/apache/arrow.gitcd arrow

          git submodule update --init --recursive
          export ARROW_TEST_DATA=$PWD/testing/data
          cd cpp
          mkdir debug
          cd debug
          cmake -DCMAKE_BUILD_TYPE=Debug -DARROW_BUILD_TESTS=ON ..
          make -j2  unittest

          baksmj Benson Muite added a comment - After using exporting ARROW_TEST_DATA all test pass, suggested steps dnf -y update dnf -y install cmake gcc gcc-c++ make python39 git git clone https://github.com/apache/arrow.gitcd arrow git submodule update --init --recursive export ARROW_TEST_DATA=$PWD/testing/data cd cpp mkdir debug cd debug cmake -DCMAKE_BUILD_TYPE=Debug -DARROW_BUILD_TESTS=ON .. make -j2  unittest
          kou Kouhei Sutou added a comment -

          You can use PYTHON=python3 make unittest for Python 3.

          kou Kouhei Sutou added a comment - You can use PYTHON=python3 make unittest for Python 3.
          baksmj Benson Muite added a comment -

          Thanks.

          baksmj Benson Muite added a comment - Thanks.
          kou Kouhei Sutou added a comment -

          https://github.com/apache/arrow/pull/11154 also includes a fix of this.

          kou Kouhei Sutou added a comment - https://github.com/apache/arrow/pull/11154 also includes a fix of this.
          rokm Rok Mihevc added a comment -

          This issue has been migrated to issue #29594 on GitHub. Please see the migration documentation for further details.

          rokm Rok Mihevc added a comment - This issue has been migrated to issue #29594 on GitHub. Please see the migration documentation for further details.

          People

            baksmj Benson Muite
            baksmj Benson Muite
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: