Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 5.0.0
    • 6.0.0
    • R

    Description

      JSON support requires RapidJSON, a third-party dependency that might not always be available. Particularly for offline static builds (ARROW-12981), it would be nice to allow ARROW_JSON=OFF.

      Here's the relevant section of ThirdpartyToolchain.cmake:

      if(ARROW_JSON)
        set(ARROW_WITH_RAPIDJSON ON)
      endif()
      

      And the relevant section of the build_arrow_static.sh script.

      As Neal mentioned, there's more to do than just replacing -DARROW_JSON=ON with -DARROW_JSON=${ARROW_JSON:-ON}. "We'll have to conditionally build some of the bindings like we do with dataset and parquet, and we'll have to conditionally skip tests."

      Attachments

        Issue Links

          Activity

            icook Ian Cook added a comment -

            Issue resolved by pull request 11046
            https://github.com/apache/arrow/pull/11046

            icook Ian Cook added a comment - Issue resolved by pull request 11046 https://github.com/apache/arrow/pull/11046
            rokm Rok Mihevc added a comment -

            This issue has been migrated to issue #18804 on GitHub. Please see the migration documentation for further details.

            rokm Rok Mihevc added a comment - This issue has been migrated to issue #18804 on GitHub. Please see the migration documentation for further details.

            People

              karldw Karl Dunkle Werner
              karldw Karl Dunkle Werner
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 4.5h
                  4.5h