Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-13670

[C++] Do a round of compiler warning cleanups

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • None
    • 6.0.0
    • C++

    Description

      During a build I found several classes without virtual destructors and some out of order initialization.

      Attachments

        Issue Links

          Activity

            I can't seem to relocate the out of order construction and most virtual destructors seem to be refactored after arrow 5.0

            emkornfield@gmail.com Micah Kornfield added a comment - I can't seem to relocate the out of order construction and most virtual destructors seem to be refactored after arrow 5.0
            apitrou Antoine Pitrou added a comment -

            Does this emit compiler warnings? Is there a problem with not having virtual destructors (I may be missing something here)?

            apitrou Antoine Pitrou added a comment - Does this emit compiler warnings? Is there a problem with not having virtual destructors (I may be missing something here)?
            apitrou Antoine Pitrou added a comment -

            Issue resolved by pull request 11148
            https://github.com/apache/arrow/pull/11148

            apitrou Antoine Pitrou added a comment - Issue resolved by pull request 11148 https://github.com/apache/arrow/pull/11148
            rokm Rok Mihevc added a comment -

            This issue has been migrated to issue #29307 on GitHub. Please see the migration documentation for further details.

            rokm Rok Mihevc added a comment - This issue has been migrated to issue #29307 on GitHub. Please see the migration documentation for further details.

            People

              emkornfield Micah Kornfield
              emkornfield Micah Kornfield
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m