Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-13584

Please do not include .ts files in npm artifacts alongside .d.ts

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 5.0.0
    • None
    • JavaScript
    • Windows 10, Typescript 4.3.5, apache-arrow@5.0.0, Node.js 14.16.0

    Description

      Using Typescript 4.3.5 I am seeing compilation issues in .ts files with the compiler option `skipLibCheck` enabled, but the module is working fine (Node.js 14.16.0)

       

      It's common for library .d.ts files to have incompatibility with the current compilation either due to missing peer-types or compiler incompatibility. I think both are happening here, but it doesn't matter for the consuming code as long as the JS is compatible (which it is) - in these cases `skipLibCheck` silences the .d.ts issues.

       

      In this package that solution does not actually silence the compiler errors because .ts files are shipped right alongside the .js and .d.ts files. 

       

      I have attached an example tsconfig.json and a log of the compiler errors I see.

      Attachments

        1. log.txt
          9 kB
          Ben Sammons
        2. tsconfig.json
          0.3 kB
          Ben Sammons

        Issue Links

          Activity

            People

              domoritz Dominik Moritz
              sammons Ben Sammons
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: