[ARROW-13243] [R] altrep function call in R 3.5

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0.0
• Component/s: R
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/28928
• Assignee: Jonathan Keane
• Reporter: Jonathan Keane
• Created: 01/Jul/21 19:32
• Updated: 11/Jan/23 08:31
• Resolved: 12/Jul/21 15:14

Description

It looks like we need some (more?) version- or altrep- gating in order to build on 3.5.

This is what is causing the nightly build test-r-versions to fail. (one example: https://github.com/ursacomputing/crossbow/runs/2959504085#step:7:1335)

/opt/R/3.5.3/lib/R/include/R_ext/Altrep.h:35:31: error: expected primary-expression before ‘class’
 R_new_altrep(R_altrep_class_t class, SEXP data1, SEXP data2);
                               ^~~~~
/opt/R/3.5.3/lib/R/include/R_ext/Altrep.h:35:43: error: expected primary-expression before ‘data1’
 R_new_altrep(R_altrep_class_t class, SEXP data1, SEXP data2);
                                           ^~~~~
/opt/R/3.5.3/lib/R/include/R_ext/Altrep.h:35:55: error: expected primary-expression before ‘data2’
 R_new_altrep(R_altrep_class_t class, SEXP data1, SEXP data2);
                                                       ^~~~~
/opt/R/3.5.3/lib/R/include/R_ext/Altrep.h:35:60: error: expression list treated as compound expression in initializer [-fpermissive]
 R_new_altrep(R_altrep_class_t class, SEXP data1, SEXP data2);
                                                            ^
altrep.cpp: In instantiation of ‘static SEXPREC* arrow::r::ArrayNoNull<sexp_type>::Make(R_altrep_class_t, const std::shared_ptr<arrow::Array>&) [with int sexp_type = 14; SEXP = SEXPREC*]’:
altrep.cpp:113:34:   required from here
altrep.cpp:47:28: error: ‘R_new_altrep’ cannot be used as a function
     SEXP res = R_new_altrep(class_t, xp, R_NilValue);
                ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
altrep.cpp: In instantiation of ‘static SEXPREC* arrow::r::ArrayNoNull<sexp_type>::Make(R_altrep_class_t, const std::shared_ptr<arrow::Array>&) [with int sexp_type = 13; SEXP = SEXPREC*]’:
altrep.cpp:127:33:   required from here
altrep.cpp:47:28: error: ‘R_new_altrep’ cannot be used as a function
/opt/R/3.5.3/lib/R/etc/Makeconf:172: recipe for target 'altrep.o' failed
make: *** [altrep.o] Error 1
make: *** Waiting for unfinished jobs....
ERROR: compilation failed for package ‘arrow’

Issue Links

• links to: GitHub Pull Request #10702