Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-13094

[R] Bindings for sign()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Duplicate
    • None
    • None
    • R
    • None

    Description

      ARROW-12861 adds a sign kernel to the C++ library. Add a mapping to this in the R package.

      I think this should be as simple as just adding

      "sign" = "sign",

      to .unary_function_map in expression.R, plus a simple test.

      Note that the C++ library's sign kernel returns integer output whereas base R's sign function returns numeric (double) output, so a test written with expect_dplyr_equal() might fail unless it explicitly converts the output from sign() using as.numeric() or as.integer().

      Attachments

        Issue Links

          Activity

            People

              npr Neal Richardson
              icook Ian Cook
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: