Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Duplicate
-
None
-
None
-
None
Description
ARROW-12861 adds a sign kernel to the C++ library. Add a mapping to this in the R package.
I think this should be as simple as just adding
"sign" = "sign",
to .unary_function_map in expression.R, plus a simple test.
Note that the C++ library's sign kernel returns integer output whereas base R's sign function returns numeric (double) output, so a test written with expect_dplyr_equal() might fail unless it explicitly converts the output from sign() using as.numeric() or as.integer().
Attachments
Issue Links
- depends upon
-
ARROW-12861 [C++][Compute] Add sign function kernels
- Resolved
- duplicates
-
ARROW-13357 [R] bindings for sign()
- Resolved