[ARROW-12935] [C++][CI] Compiler error on some clang versions

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 5.0.0
• Component/s: C++, Continuous Integration
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/28661
• Assignee: Antoine Pitrou
• Reporter: Antoine Pitrou
• Created: 02/Jun/21 12:08
• Updated: 11/Jan/23 08:29
• Resolved: 02/Jun/21 12:56

Description

My bad: I merged ARROW-12859 without noticing that there was a compilation error on some CI configurations.

/Users/runner/work/arrow/arrow/cpp/src/arrow/ipc/json_simple_test.cc:1362:63: error: implicit conversion from 'double' to 'bool' changes value from -0 to false [-Werror,-Wliteral-conversion]
  AssertJSONScalar<DoubleType, bool>(float64(), "-0.0", true, -0.0);
  ~~~~~~~~~~~~~~~~                                            ^~~~

Issue Links

• links to: GitHub Pull Request #10435