[ARROW-12601] [R][Packaging] Fix pkg-config check in r/configure

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.0.1, 5.0.0
• Component/s: Packaging, R
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/28355
• Assignee: Ian Cook
• Reporter: Ian Cook
• Created: 29/Apr/21 15:52
• Updated: 11/Jan/23 08:27
• Resolved: 29/Apr/21 21:33

Description

I installed the arrow R package version 4.0.0 from CRAN on an Intel Mac that does not have pkg-config installed, and I saw this in the installation log

./configure: line 81: pkg-config: command not found
./configure: line 82: pkg-config: command not found
./configure: line 83: pkg-config: command not found 

This is happening because of line 79 and 80:

pkg-config --version >/dev/null 2>&1
if [ "$ARROW_USE_PKG_CONFIG" != "false" ] && [ $? -eq 0 ]; then 

The first conditional on line 80 causes $? to be set to 0, so then the second conditional evaluates to true. Reverse the order of these two conditionals so that $? truly reflects whether pkg-config is installed.

Issue Links

• links to: GitHub Pull Request #10198