Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-12601

[R][Packaging] Fix pkg-config check in r/configure

    XMLWordPrintableJSON

Details

    Description

      I installed the arrow R package version 4.0.0 from CRAN on an Intel Mac that does not have pkg-config installed, and I saw this in the installation log

      ./configure: line 81: pkg-config: command not found
      ./configure: line 82: pkg-config: command not found
      ./configure: line 83: pkg-config: command not found 

      This is happening because of line 79 and 80:

      pkg-config --version >/dev/null 2>&1
      if [ "$ARROW_USE_PKG_CONFIG" != "false" ] && [ $? -eq 0 ]; then 

      The first conditional on line 80 causes $? to be set to 0, so then the second conditional evaluates to true. Reverse the order of these two conditionals so that $? truly reflects whether pkg-config is installed.

      Attachments

        Issue Links

          Activity

            People

              icook Ian Cook
              icook Ian Cook
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h