[ARROW-11872] [C++] Array Validation of GPU buffers fails due to incorrect validation check

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 4.0.0
• Component/s: C++, GPU, Python
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/18548
• Assignee: Paul Taylor
• Reporter: Prem Sagar Gali
• Created: 05/Mar/21 14:57
• Updated: 11/Jan/23 08:22
• Resolved: 09/Mar/21 11:34

Description

Whenever we try to create an array or a Table from a GPU buffer we get the following Invalid missing values buffer error.

pyarrow/table.pxi:485: in pyarrow.lib.chunked_array
 ???
 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ > ???
 E pyarrow.lib.ArrowInvalid: In chunk 0: Invalid: Missing values buffer in non-empty arraypyarrow/error.pxi:84: ArrowInvalid

This is because the GPU buffers aren't passing the following validation check: https://github.com/apache/arrow/blob/7be266be98d08214ef4b3f067059b6e6a8a6e5c0/cpp/src/arrow/array/validate.cc#L183

 

But this has to be changed to something like: 

static bool IsBufferValid(const ArrayData& data, int index)
{ return data.buffers[index] != nullptr && (data.buffers[index]->is_cpu() ? data.buffers[index]->data() != nullptr : true); }

 

Issue Links

• links to: GitHub Pull Request #9640