Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-11801

[C++] Remove bad header guard in filesystem/type_fwd.h

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 4.0.0
    • Component/s: C++

      Description

      There is an #if defined(ARROW_R_WITH_S3) here in cpp/src/arrow/filesystem/type_fwd.h:

      https://github.com/apache/arrow/commit/b058cf0d1c26ad7984c104bb84322cc7dcc66f00#diff-be848bca05dd0e7f650673782a2[…]9778ca59d674ea64cd639e6a7853e2R47

      There should not be any of these R-specific guards outside of r/src. Remove it.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                icook Ian Cook
                Reporter:
                icook Ian Cook
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m