Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-11746

[Developer][Archery] Fix prefer real time check

    XMLWordPrintableJSON

Details

    Description

      Google Benchmark adds /real_time to the end of the benchmark name to indicate if the real_time observation should be preferred over the cpu_time observation.

      https://github.com/google/benchmark/blob/af72911f2fe6b8114564614d2db17a449f8c4af0/src/benchmark_register.cc#L222

      Example: AllocateDeallocate<Jemalloc>/size:1048576/real_time

      Archery is looking for "/realtime", not "/real_time" though.

       @property
       def is_realtime(self):
           """ Indicate if the preferred value is realtime instead of cputime. """
           return self.name.find("/realtime") != -1
      

      Attachments

        Issue Links

          Activity

            People

              dianaclarke Diana Clarke
              dianaclarke Diana Clarke
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m