[ARROW-11710] [Rust][DataFusion] Implement ExprRewriter to avoid tree traversal redundancy

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0
• Component/s: Rust - DataFusion
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/27569
• Assignee: Andrew Lamb
• Reporter: Andrew Lamb
• Created: 20/Feb/21 10:46
• Updated: 11/Jan/23 08:21
• Resolved: 26/Feb/21 19:53

Description

The idea is to
1. Reduce the amount repetitions in optimizer rules to make them easier to implement

2. Reduce the amount of repetition to make it easier to see the actual logic (rather than having it intertwined with the code needed to do recursion)

2. Set the stage for a more general `PlanRewriter` that doesn't have to clone its input, and can modify take their input by value and consume them

Plan is to make an ExprRewriter, the mutable counterpart to `ExpressionVisitor` and demonstrates its usefulness by rewriting several expression transformation rewrite passes using it.

Issue Links

• relates to: ARROW-10243 [Rust] [Datafusion] Optimize literal expression evaluation
• links to: GitHub Pull Request #9545