[ARROW-11680] [C++] Add vendored version of folly's spsc queue

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/27543
• Assignee: Weston Pace
• Reporter: Weston Pace
• Created: 18/Feb/21 00:27
• Updated: 11/Jan/23 08:21
• Resolved: 09/Mar/21 15:16

Description

Rationale for vendoring:

Folly contains hundreds of files, requires boost & C++14.  The ProducerConsumerQueue class could be extracted out of three of those files and hasn't been changed since 2018.  The queue does not appear to have any open issues.

Comparisons with alternatives:

I have included a benchmark comparing folly with boost (since boost::lockfree::spsc_queue is already included in arrow, I think).  Boost does not support a move workflow for spsc_queue and performs worse.

I have not compared with any other alternatives but the utility is small and straightforward enough I am doubtful there would be significant differences.

Issue Links

• links to: GitHub Pull Request #9519