Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-11375

[Rust] CI fails due to deprecation warning in clippy

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 4.0.0
    • Rust

    Description

      Rust clippy lint test on CI started failing with this error:

         Compiling arrow-flight v3.0.0-SNAPSHOT (/__w/arrow/arrow/rust/arrow-flight)
      error: use of deprecated struct `criterion::Benchmark`: Please use BenchmarkGroups instead.
        --> arrow/benches/builder.rs:39:9
         |
      39 |         Benchmark::new("bench_primitive", move |b| {
         |         ^^^^^^^^^^^^^^
         |
         = note: `-D deprecated` implied by `-D warnings`
      
      error: use of deprecated struct `criterion::Benchmark`: Please use BenchmarkGroups instead.
        --> arrow/benches/builder.rs:62:9
         |
      62 |         Benchmark::new("bench_bool", move |b| {
         |         ^^^^^^^^^^^^^^
      
      error: use of deprecated associated function `criterion::Criterion::<M>::bench`: Please use BenchmarkGroups instead.
        --> arrow/benches/builder.rs:37:7
         |
      37 |     c.bench(
         |       ^^^^^
      
      error: use of deprecated associated function `criterion::Criterion::<M>::bench`: Please use BenchmarkGroups instead.
        --> arrow/benches/builder.rs:60:7
         |
      60 |     c.bench(
         |       ^^^^^
      

      It appears related to the latest release of criterion: https://crates.io/crates/criterion/0.3.4 (On Jan 24 2021)

      Attachments

        Issue Links

          Activity

            People

              jorgecarleitao Jorge Leitão
              alamb Andrew Lamb
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h