Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-11101

[Rust] enable "cargo +nightly fmt" in git pre-commit hook

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0
    • Rust

    Description

      Currently,  the client side git pre-commit hook checks and runs `cargo fmt` with stable version, but the CI check may fail in nightly version occasionally even if the code has been formatted with stable.

      It seems that, this problem can be resolved by: running `cargo +nighty fmt` before  `cargo +stable fmt`. Thus `pre-commit.sh` should be updated in this way.

      Attachments

        Issue Links

          Activity

            People

              mqy Qingyou Meng
              mqy Qingyou Meng
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m