[ARROW-10840] [C++] Parquet FileMetaData does not have key_value_metadata when built from FileMetaDataBuilder

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0, 1.0.1, 2.0.0
• Fix Version/s: 3.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/26776
• Assignee: Jimmy Lu
• Reporter: Jimmy Lu
• Created: 07/Dec/20 23:07
• Updated: 11/Jan/23 08:15
• Resolved: 04/Jan/21 16:32

Description

FileMetaDataImpl::key_value_metadata_ is initialized in the constructor: https://github.com/apache/arrow/blob/apache-arrow-1.0.0/cpp/src/parquet/metadata.cc#L530

But in RowGroupMetaDataBuilder::Finish, FileMetaDataImpl::metadata_ is set after the construction and we are missing the FileMetaDataImpl::InitKeyValueMetadata call here: https://github.com/apache/arrow/blob/apache-arrow-1.0.0/cpp/src/parquet/metadata.cc#L1412

Issue Links

• links to: GitHub Pull Request #9012