[ARROW-10692] [Rust] Segfault while array buffer append

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 3.0.0
• Component/s: Rust
• Labels: pull-request-available
• Environment: Ubuntu 20.04. rustc-nightly,
• External issue URL: https://github.com/apache/arrow/issues/26643
• Assignee: Jorge Leitão
• Reporter: Ziru Niu
• Created: 23/Nov/20 04:52
• Updated: 11/Jan/23 08:14
• Resolved: 01/Jan/21 09:17

Description

// src/buffer.rs:657
   
    /// Ensures that this buffer has at least `capacity` slots in this buffer. This will
    /// also ensure the new capacity will be a multiple of 64 bytes.
    ///
    /// Returns the new capacity for this buffer.
    pub fn reserve(&mut self, capacity: usize) -> Result<usize> {
        if capacity > self.capacity {
            unsafe { memory :: reallocate(self.data, self.capacity, new_capacity) };
            self.data = new_data as *mut u8;
            self.capacity = new_capacity;
        }
        Ok(self.capacity)
    }

 
Above code is not checking if new_data is null, which is causing segfault on following memcpy when reallocate failed.

Issue Links

• Blocked: ARROW-10691 Segfault in
• relates to: ARROW-11048 [Rust] Add bench to MutableBuffer
• links to: GitHub Pull Request #8997