[ARROW-10448] [Rust] PrimitiveArray::new can create arrays not in spec

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: Rust
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/18349
• Assignee: Jorge Leitão
• Reporter: Jorge Leitão
• Created: 31/Oct/20 05:11
• Updated: 11/Jan/23 08:13
• Resolved: 07/Nov/20 13:13

Description

Currently, PrimitiveArray::new passed with `null_count != 0` creates an array that does not follow the specification, as it is initialized with a None null bitmap but a non-zero null_count.

This method also makes no attempt to check for the buffer's aligment, which leads to UB.

Since a change in this method's signature requires a backward incompatible change, and it is only used in tests, I propose that we just remove it: we have good offers to create primitive arrays:

• from an ArrayData,
• from a vector or vector of optionals
• from an iterator

which covers all major cases.

Issue Links

• links to: GitHub Pull Request #8560