Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-10397

[C++] Outdated and confusing comment on dictionary indices

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • None
    • 3.0.0
    • C++

    Description

      While working on the Rust implementation, I got confused by this comment that said dictionary index types could be assumed to be signed integers. The Rust code allowed for unsigned integers, so I thought the Rust code had a bug. However, I read the C++ code more carefully, and unsigned integers are allowed as dictionary index types-- this was changed in this commit but the comment wasn't updated.

      I have a pull request fixing the comment, just want to save someone a few minutes of confusion

      Attachments

        Issue Links

          Activity

            People

              carols10cents Carol Nichols
              carols10cents Carol Nichols
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m