Uploaded image for project: 'Apache Arrow'
  1. Apache Arrow
  2. ARROW-10325

[C++][Compute] Separate aggregate kernel registration

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0
    • Component/s: C++

      Description

      We have basic aggregate kernel 'count/mean/sum/min_max' implemented in one file (plus simd version) and more complicated 'mode' and 'variance/stddev' kernels implemented in separated files.
      'mode' and 'variance/stddev' kernels are now registered together with basic kernels in aggregate_basic.cc. And there are 'mode' and 'variance/stddev' kernel related function definitions in aggregate_basic_internal.h.
      This is not good. They should be moved from basic kernel source to their own implementation files and registered separately.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                yibo Yibo Cai
                Reporter:
                yibo Yibo Cai
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m