Details
-
Improvement
-
Status: Resolved
-
Trivial
-
Resolution: Fixed
-
None
Description
We have basic aggregate kernel 'count/mean/sum/min_max' implemented in one file (plus simd version) and more complicated 'mode' and 'variance/stddev' kernels implemented in separated files.
'mode' and 'variance/stddev' kernels are now registered together with basic kernels in aggregate_basic.cc. And there are 'mode' and 'variance/stddev' kernel related function definitions in aggregate_basic_internal.h.
This is not good. They should be moved from basic kernel source to their own implementation files and registered separately.
Attachments
Issue Links
- links to