[ARROW-10064] [C++] Resolve compile warnings on Apple Clang 12

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/26084
• Assignee: Krisztian Szucs
• Reporter: Krisztian Szucs
• Created: 22/Sep/20 12:42
• Updated: 11/Jan/23 08:10
• Resolved: 22/Sep/20 14:51

Description

../src/arrow/util/uri.cc:172:19: error: loop variable 'seg' of type 'const nonstd::sv_lite::basic_string_view<char, std::__1::char_traits<char> >' creates a copy from type 'const nonstd::sv_lite::basic_string_view<char, std::__1::char_traits<char> >' [-Werror,-Wrange-loop-analysis]
  for (const auto seg : segments) {
                  ^
../src/arrow/util/uri.cc:172:8: note: use reference type 'const nonstd::sv_lite::basic_string_view<char, std::__1::char_traits<char> > &' to prevent copying
  for (const auto seg : segments) {
       ^~~~~~~~~~~~~~~~
                  & 

../src/arrow/ipc/metadata_internal.cc:1157:20: error: loop variable 'pair' is always a copy because the range of type 'const arrow::ipc::internal::KVVector' (aka 'const Vector<Offset<flatbuf::KeyValue> >') does not return a reference [-Werror,-Wrange-loo
p-analysis]
  for (const auto& pair : *fb_metadata) {
                   ^
../src/arrow/ipc/metadata_internal.cc:1157:8: note: use non-reference type 'const org::apache::arrow::flatbuf::KeyValue *'
  for (const auto& pair : *fb_metadata) {
       ^~~~~~~~~~~~~~~~~~

Issue Links

• links to: GitHub Pull Request #8239