[ARIES-971] ServiceHelper.CacheClearoutListener.add(BundleContext, ServiceKey) causes NPE if system bundle is hidden

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: jndi-url-1.1.0
• Component/s: JNDI

Environment

All

• Assignee: Mark Nuttall
• Reporter: Tom Watson
• Created: 26/Nov/12 15:14
• Updated: 15/Oct/14 16:09
• Resolved: 26/Nov/12 15:27

Description

In org.apache.aries.jndi.services.ServiceHelper.CacheClearoutListener.add(BundleContext, ServiceKey) the following code will cause an NPE:

// try to use the system bundle for our listener,
// if that fails we fall back to the calling context
BundleContext systemBundle =
AccessController.doPrivileged(new PrivilegedAction<BundleContext>() {
public BundleContext run()

{ return ctx.getBundle(0).getBundleContext(); <<< NPE here }

});

This can happen if a bundle FindHook hides the bundle 0 from the ctx bundle. A check for null should be done here:

BundleContext systemBundle =
AccessController.doPrivileged(new PrivilegedAction<BundleContext>() {
public BundleContext run()

{ Bundle system = ctx.getBundle(0); return system == null ? null : system.getBundleContext(); }

});

This would allow jndi to work in such environments where bundle, service, and resolver hooks are used for isolation (e.g. subsystems).