Uploaded image for project: 'Aries'
  1. Aries
  2. ARIES-355

Web itests - clean-up

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.2
    • 0.2
    • Web
    • None

    Description

      I've applied some minor changes to the WabConverterITest class. I took a look at this class after seeing logs from build #580 (WabConverterITest failed in #580).However, the changes I propose are not really related with the issue observed in #580 - they are rather meant to do clean up.

      In order to get rid of the issue observed in #580 it might be necessary to increase the amount of time this test waits for the WAR URL Stream Handler Service. TIt currently waits 10 seconds. I guess this could be increased to 15 seconds:
      URLStreamHandlerService warHandler = getOsgiService(URLStreamHandlerService.class,
      "(url.handler.protocol=webbundle)", 15000);
      or even to the default timeout which is 30 seconds.

      Changes that applied in the patch
      1. fout.close() added
      2. Service tracker references kept and closed during test teardown
      3. Service tracker used instead of bundleContext.getServiceReferences()
      4. There's no need to check urlhandler bundle state. Checking if the WAR URL Stream Handler Service is present should be sufficient.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            gawor@mcs.anl.gov Jarek Gawor
            bartosz Bartosz Kowalewski
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment