[ARIES-1885] JpaInterceptor does not properly end coordination in case of Exception

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: jpa-2.7.1
• Fix Version/s: jpa-2.7.2
• Component/s: JPA
• Assignee: Christian Schneider
• Reporter: Nicolas Dutertry
• Created: 29/Jan/19 15:01
• Updated: 01/Feb/19 13:18
• Resolved: 30/Jan/19 13:37

Description

In class JpaInterceptor the method postCallWithException calls Coordination.fail() but not Coordination.end():

@Override
public void postCallWithException(ComponentMetadata cm, Method m, Throwable ex, Object preCallToken) {
    LOG.debug("PostCallWithException for bean {}, method {}", cm.getId(), m.getName(), ex);
    if (preCallToken != null) {
        ((Coordination)preCallToken).fail(ex);
    }
}

 

However, the javadoc of Coordination.fail() states:

If this Coordination has been {@link #push() pushed} onto a thread local Coordination stack, this Coordination is not removed from the stack. The creator of this Coordination must still call {@link #end()} on this Coordination to cause it to be removed from the thread local Coordination stack.

This is causing issues for subsequent calls to jpa service because the coordination is not removed from the stack.

The method postCallWithException should be implemented like this:

@Override
public void postCallWithException(ComponentMetadata cm, Method m, Throwable ex, Object preCallToken) {
    LOG.debug("PostCallWithException for bean {}, method {}", cm.getId(), m.getName(), ex);
    if (preCallToken != null) {
        Coordination coordination = (Coordination)preCallToken;
        coordination.fail(ex);
        coordination.end();
    }
}

 

Issue Links

• links to: GitHub Pull Request #6