Uploaded image for project: 'Aries'
  1. Aries
  2. ARIES-1805

Blueprint core does not honor Java beans specification

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: blueprint-core-1.8.0
    • Fix Version/s: blueprint-core-1.10.0
    • Component/s: Blueprint
    • Labels:
      None

      Description

      Aries blueprint core, to consider a property legit, checks that is and get access methods are not present at the same time: https://github.com/apache/aries/blob/trunk/blueprint/blueprint-core/src/main/java/org/apache/aries/blueprint/utils/ReflectionUtils.java#L222-L255 specifically: https://github.com/apache/aries/blob/trunk/blueprint/blueprint-core/src/main/java/org/apache/aries/blueprint/utils/ReflectionUtils.java#L249

      looking at java bean specification: http://download.oracle.com/otn-pub/jcp/7224-javabeans-1.01-fr-spec-oth-JSpec/beans.101.pdf?AuthParam=1527758194_593d6e2c9336cf75e216a3333390c7b9
      it seems that both access methods (is and get) are allowed to be present at the same time, in that case, the is has to be used:

      8.3.2 Boolean properties In addition, for boolean properties, we allow a getter method to match the pattern: public boolean is<PropertyName>(); This “is<PropertyName>” method may be provided instead of a “get<PropertyName>” method, or it may be provided in addition to a “get<PropertyName>” method. In either case, if the “is<PropertyName>” method is present for a boolean property then we will use the “is<PropertyName>” method to read the property value.

      Should the Aries implementation be modified accordingly?

      I've provided a test case in this PR https://github.com/apache/aries/pull/85

      If possible, would be nice to have this available to version 1.8.0 as well.

        Attachments

          Activity

            People

            • Assignee:
              gnodet Guillaume Nodet
              Reporter:
              valdar Andrea Tarocchi

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 10m
                10m

                  Issue deployment